Skip to content

refactor: simplify tray color/count updates #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 9, 2025
Merged

refactor: simplify tray color/count updates #2339

merged 15 commits into from
Nov 9, 2025
+755 −389

Conversation

@setchy
Copy link
Member

@setchy setchy commented Oct 30, 2025 •
edited
Loading

Simply logic around tray color/count updates, as well as fix a bug with the unread count when using delayNotificationState

@github-actions github-actions bot added the bug Something isn't working label Oct 30, 2025
@setchy setchy changed the title fix: correctly set count when using delayNotificationState fix: correctly set accurte unread count when using delayNotificationState Oct 30, 2025
@setchy setchy changed the title fix: correctly set accurte unread count when using delayNotificationState fix: set accurte unread count when using delayNotificationState Oct 30, 2025
@setchy setchy changed the title fix: set accurte unread count when using delayNotificationState fix: set correct unread count when using delayNotificationState Oct 30, 2025
@setchy setchy marked this pull request as draft November 8, 2025 21:09
@setchy setchy changed the title fix: set correct unread count when using delayNotificationState refactor: simplify tray color/count updates Nov 8, 2025
@github-actions github-actions bot added refactor Refactoring of existing feature and removed bug Something isn't working labels Nov 8, 2025
setchy added 8 commits November 9, 2025 08:05
@setchy
refactor simplify
2c332be 
Signed-off-by: Adam Setch <[email protected]>
@setchy
refactor simplify
068a993 
Signed-off-by: Adam Setch <[email protected]>
@setchy
refactor simplify
eb6e10d 
Signed-off-by: Adam Setch <[email protected]>
@setchy
refactor simplify
bd77663 
Signed-off-by: Adam Setch <[email protected]>
@setchy
refactor
8e6f79e 
Signed-off-by: Adam Setch <[email protected]>
@setchy
Merge branch 'main' into feat/count-unread-only
dfa82df 
Signed-off-by: Adam Setch <[email protected]>
@setchy
test coverage
1cc6ab1 
Signed-off-by: Adam Setch <[email protected]>
@setchy
test coverage
34927a7 
Signed-off-by: Adam Setch <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@setchy setchy marked this pull request as ready for review November 9, 2025 16:55
@setchy setchy merged commit 4b5ed0f into main Nov 9, 2025
16 checks passed
@setchy setchy deleted the feat/count-unread-only branch November 9, 2025 16:55
@github-actions github-actions bot added this to the Release 6.11.0 milestone Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees

No one assigned

Labels

refactor Refactoring of existing feature

Milestone

Release 6.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@setchy